Skip to content

[Feature] Avoid duplicate error notifications #2963

Open

Description

@EmmaYuan1015

Description

When the Install Pods command fails while checking the CocoaPods version, the error is displayed twice.

The inner catch block logs and displays the error, then rethrows it to the outer catch, which logs and displays it again.

Expected behavior

The inner catch should add context and rethrow the error. Error logging and user notification should be handled once by the outer catch.

Proposed fix

  • Remove logging and notification from the inner catch.
  • Preserve the original error details when rethrowing.
  • Add a regression test verifying that the error is displayed only once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions