Skip to content

fix: support array form of tsconfig "extends" in document links #318263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unrevised6419 wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −5
Open

fix: support array form of tsconfig "extends" in document links #318263

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36a282c
fix: support array form of tsconfig "extends" in document links
unrevised6419 May 25, 2026
0e1d78c
refactor: explicit return types and inline coalesce in tsconfig link …
unrevised6419 May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions extensions/typescript-language-features/src/languageFeatures/tsconfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,24 @@ class TsconfigLinkProvider implements vscode.DocumentLinkProvider {
}

return coalesce([
this.getExtendsLink(document, root),
...this.getExtendsLinks(document, root),
...this.getFilesLinks(document, root),
...this.getReferencesLinks(document, root)
]);
}

private getExtendsLink(document: vscode.TextDocument, root: jsonc.Node): vscode.DocumentLink | undefined {
private getExtendsLinks(document: vscode.TextDocument, root: jsonc.Node) {
const node = jsonc.findNodeAtLocation(root, ['extends']);
return node && this.tryCreateTsConfigLink(document, node, TsConfigLinkType.Extends);

if (!node) {
return [];
}

if (node.type === 'array') {
return mapChildren(node, child => this.tryCreateTsConfigLink(document, child, TsConfigLinkType.Extends));
}

return [this.tryCreateTsConfigLink(document, node, TsConfigLinkType.Extends)];
}
Comment thread
unrevised6419 marked this conversation as resolved.
Outdated

private getReferencesLinks(document: vscode.TextDocument, root: jsonc.Node) {
Expand Down