Fix runTests tool not handling absolute file paths for remote workspaces#318278
Open
felipecrs wants to merge 10 commits into
Open
Fix runTests tool not handling absolute file paths for remote workspaces#318278felipecrs wants to merge 10 commits into
runTests tool not handling absolute file paths for remote workspaces#318278felipecrs wants to merge 10 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds coverage and implementation to ensure RunTestTool resolves absolute file paths correctly when running in remote workspaces.
Changes:
- Update
RunTestToolto resolve paths against the first workspace folder when the workspace is remote (non-fileURI scheme). - Add tests validating URI resolution behavior for absolute paths in remote vs local workspaces.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/testing/common/testingChatAgentTool.ts | Adjusts file-to-URI conversion to support remote workspace URIs. |
| src/vs/workbench/contrib/testing/test/common/testingChatAgentTool.test.ts | Adds test cases to validate URI resolution for absolute paths in remote/local workspaces. |
felipecrs
force-pushed
the
fix-runtests-tool-absolute-paths-remote
branch
from
e0db5fd to
6b03aaa
Compare
felipecrs
force-pushed
the
fix-runtests-tool-absolute-paths-remote
branch
2 times, most recently
from
d3c7571 to
276fdf1
Compare
felipecrs
force-pushed
the
fix-runtests-tool-absolute-paths-remote
branch
from
276fdf1 to
473f297
Compare
felipecrs
force-pushed
the
fix-runtests-tool-absolute-paths-remote
branch
from
ab42bf4 to
c8275f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows #317904 after extending the fix to also handle absolte paths for remote workspaces after being able to test it.
A better description of this specific issue and how to test this PR can be found here.
PS: I was able to verify this patch before proposing it. It works as expected.