fix(breadcrumbs): handle missing tree element in outline picker#318323
Open
SpencerJung wants to merge 1 commit into
Open
fix(breadcrumbs): handle missing tree element in outline picker#318323SpencerJung wants to merge 1 commit into
SpencerJung wants to merge 1 commit into
Conversation
…osoft#316635) BreadcrumbsOutlinePicker._setInput could throw TreeError when the element was not yet present in the tree during reveal/setFocus calls. - Wrap reveal and setFocus in try-catch to gracefully handle missing elements Fixes microsoft#316635
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR makes the breadcrumbs outline picker more resilient when attempting to reveal/focus an outline element that may not yet exist in the tree.
Changes:
- Wrap
tree.revealandtree.setFocusin atry/catchto avoid failures when the element isn’t yet present.
Comment on lines
+496
to
+501
| try { | ||
| tree.reveal(input.element, 0.5); | ||
| tree.setFocus([input.element], this._fakeEvent); | ||
| } catch { | ||
| // element may not be in tree yet | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #316635
Summary
BreadcrumbsOutlinePicker._setInput could throw TreeError "Tree element not found" when calling tree.reveal/tree.setFocus on an element that was not yet present in the tree.
Changes
Verification Evidence
npm run compile-check-ts-native: PASSED (no TypeScript errors)Checklist