fix(breadcrumbs): show info when no symbols to copy#318326
Open
SpencerJung wants to merge 1 commit into
Open
Conversation
The 'Copy Breadcrumbs Path' command silently did nothing when there were no breadcrumb symbols to copy (e.g. when not focused on a symbol or in files without symbol support). This was confusing because users couldn't tell if the command worked or not. - Show an info notification when there are no breadcrumb symbols to copy Fixes microsoft#286240
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a user-facing notification when the “Copy Breadcrumb Path” action has nothing to copy.
Changes:
- Injects
INotificationServiceinto theCopyBreadcrumbPathaction handler. - Shows an info notification when no breadcrumb labels/symbols are available to copy.
Comment on lines
996
to
999
| if (labels.length === 0) { | ||
| notificationService.info(localize('cmd.copyPath.noSymbols', "No breadcrumb symbols to copy.")); | ||
| return; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #286240
Summary
The 'Copy Breadcrumbs Path' command silently did nothing when there were no breadcrumb symbols to copy (e.g. when not focused on a symbol or in files without symbol support). This was confusing because users couldn't tell if the command worked or not.
Changes
Verification Evidence
npm run compile-check-ts-native: PASSED (no TypeScript errors)Checklist