fix(cargo-wdk): workspace resolution in build and clean actions to match cargo

[Shravan Vasista (svasista-ms)]

TBD

Resolves #477

[Copilot]

Pull request overview

This PR updates cargo-wdk’s build and clean flows to better match Cargo’s workspace resolution behavior (Issue #477), especially when invoked from within a workspace subdirectory.

Changes:

• Pass the Metadata provider into CleanAction and use cargo metadata to detect workspaces before falling back to “emulated workspace” scanning.
• Add a NotAbsolute error variant for clean to mirror build’s handling of unexpected non-absolute paths.
• Add/adjust CleanAction unit tests for the new workspace-detection behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
crates/cargo-wdk/src/cli.rs	Wires Metadata into CleanAction::new(...) so clean can query cargo metadata.
crates/cargo-wdk/src/actions/clean/mod.rs	Adds workspace detection via cargo metadata before emulated workspace scanning.
crates/cargo-wdk/src/actions/clean/error.rs	Adds NotAbsolute error variant for workspace root resolution failures.
crates/cargo-wdk/src/actions/build/mod.rs	Adds workspace-root inference attempt when Cargo.toml is not in the current directory.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Codecov Comments Bot (codecov-commenter)]

Codecov Report

❌ Patch coverage is 94.75806% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.62%. Comparing base (8e88dd8) to head (00c5193).

Files with missing lines	Patch %	Lines
crates/cargo-wdk/src/actions/build/mod.rs	61.53%	4 Missing and 1 partial ⚠️
crates/cargo-wdk/src/actions/clean/mod.rs	93.67%	4 Missing and 1 partial ⚠️
crates/cargo-wdk/src/cli.rs	0.00%	0 Missing and 2 partials ⚠️
crates/cargo-wdk/src/actions/mod.rs	99.35%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
+ Coverage   82.18%   82.62%   +0.44%     
==========================================
  Files          25       26       +1     
  Lines        6287     6516     +229     
  Branches     6287     6516     +229     
==========================================
+ Hits         5167     5384     +217     
- Misses        989      998       +9     
- Partials      131      134       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

crates/cargo-wdk/src/actions/mod.rs:149

• find_workspace_root always returns cargo_metadata.workspace_root, which for a workspace member subdirectory (e.g. member/src/) will typically be the workspace root, not the nearest package root. In BuildAction::run this causes cargo wdk build from inside a member subtree to build/package every workspace member (because it later runs from the workspace root), which diverges from cargo build’s “nearest Cargo.toml” behavior and can significantly increase build time.

    absolute(cargo_metadata.workspace_root.as_std_path()).ok()

crates/cargo-wdk/src/actions/mod.rs:147

• The is_emulated_workspace early-return makes find_workspace_root return None even when cargo metadata successfully identifies a real workspace, solely because the current directory contains non-member Cargo.toml children. That preserves “emulated workspace” behavior, but it also means cargo wdk build/clean can still diverge from cargo inside an actual workspace (cargo would ignore those excluded projects and operate on the workspace it found). If the PR goal is to “match cargo”, consider gating this behavior behind an explicit flag or removing it when a workspace is detected.

This issue also appears on line 149 of the same file.

    let is_emulated_workspace = dirs.iter().any(|entry| {
        entry.is_dir
            && fs.exists(&entry.path.join("Cargo.toml"))
            && absolute(&entry.path).is_ok_and(|child_dir| {
                !member_dirs
                    .iter()
                    .any(|member| member.starts_with(&child_dir))
            })
    });
    if is_emulated_workspace {
        return None;
    }

crates/cargo-wdk/src/actions/build/mod.rs:178

• New workspace-root resolution logic in BuildAction::run isn’t covered by the existing build action unit tests (there don’t appear to be tests for the “no Cargo.toml in cwd but inside a workspace” path, or for ensuring a member subdirectory builds only the selected package vs the whole workspace). This path is central to #477 and can regress behavior/perf without a test.

        // Standalone driver/driver workspace support
        if self.fs.exists(&self.working_dir.join("Cargo.toml")) {
            return self.run_from_workspace_root(&self.working_dir);
        }

        let dirs = self.fs.read_dir_entries(&self.working_dir)?;

        if let Some(workspace_root) = super::find_workspace_root(
            self.metadata,
            self.fs,
            &self.working_dir,
            &dirs,
            self.locked,
            self.features,
        ) {
            debug!(
                "Working directory {} lies inside the workspace rooted at {}; running build from \
                 workspace root",
                self.working_dir.display(),
                workspace_root.display()
            );
            return self.run_from_workspace_root(&workspace_root);
        }

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (4)

crates/cargo-wdk/src/actions/mod.rs:36

• trim_start_matches(r"\\?\") will break verbatim UNC paths like \\?\UNC\server\share\... by producing an invalid path (UNC\server\share\...). That means workspace resolution via cargo metadata can still fail for network shares. Handle the \\?\UNC\ prefix explicitly (mapping it back to a standard UNC path) and avoid string conversion when no verbatim prefix is present.

    let working_dir_trimmed: PathBuf = working_dir
        .to_string_lossy()
        .trim_start_matches(r"\\?\")
        .into();

crates/cargo-wdk/src/actions/mod.rs:24

• The doc comment for find_workspace_root is incomplete/misleading: the function also returns None when the working directory is treated as an "emulated workspace" (non-member child projects), and it uses dirs for that decision. Consider documenting that exception so callers understand when a workspace root will not be returned.

/// Resolves the root of the workspace for a working directory that has no
/// `Cargo.toml` of its own.

crates/cargo-wdk/src/actions/build/mod.rs:204

• This path now runs cargo metadata in find_workspace_root and then immediately calls run_from_workspace_root, which runs cargo metadata again (via get_cargo_metadata at actions/build/mod.rs:381 and run_from_workspace_root at :292). For large workspaces, this doubles the metadata cost for the common "cwd without Cargo.toml" case. Consider refactoring to reuse the first metadata result (e.g., have the helper return the parsed metadata or a workspace_root + workspace_packages) to avoid the second invocation.

        let dirs = self.fs.read_dir_entries(&self.working_dir)?;

        if let Some(workspace_root) = super::find_workspace_root(
            self.metadata,
            self.fs,

crates/cargo-wdk/src/actions/clean/mod.rs:105

• This new workspace-root probe changes the documented control flow of CleanAction::run (the doc comment above still says that when there is no Cargo.toml we always treat the directory as an emulated workspace). Since the doc comment isn’t in a changed hunk, consider at least adding a local note here and updating the higher-level docs in the same PR.

        let dirs = self.fs.read_dir_entries(&self.working_dir)?;

        if let Some(workspace_root) = super::find_workspace_root(
            self.metadata,
            self.fs,