Skip to content

fix(cargo-wdk): remove network dependency from automatic test signing #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Shravan Vasista (svasista-ms) wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix(cargo-wdk): remove network dependency from automatic test signing #725

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e437f4
fix(cargo-wdk): remove network dependency from automatic test signing
svasista-ms Aug 25, 2026
74de8da
fix(tests): ensure non-empty output for certmgr certificate lookup mock
svasista-ms Aug 31, 2026
6c168ea
fix: improve trace log formatting for test certificate thumbprints
svasista-ms Aug 31, 2026
4fe7a3c
Merge branch 'main' into fix/631-offline-test-signing
svasista-ms Sep 1, 2026
a48ac38
style: re-wrap comment for nightly-2026-08-31 rustfmt
svasista-ms Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/cargo-wdk/src/actions/build/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ pub enum PackageTaskError {
VerifyCertExistsInStoreInvalidCommandOutput(#[source] FromUtf8Error),
#[error("Error generating certificate to cert store using makecert")]
CertGenerationInStoreCommand(#[source] CommandError),
#[error("No usable test certificate was found in the store after creating one")]
NoUsableCertificate,
Comment on lines +77 to +78
#[error("Error while acquiring mutex for generating certificate. HRESULT: {0:#x}")]
CertMutexError(i32),
#[error("Error signing {} using signtool", .file.display())]
Expand Down
Loading
Loading