-
Notifications
You must be signed in to change notification settings - Fork 38
local env usability fixes #1807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
justinfrevert
wants to merge
10
commits into
main
Choose a base branch
from
fix/local-env-usability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5f77988
Debug runtime upgrade job
justinfrevert f398dd3
Try fixing connection details
justinfrevert 4b7607c
runtime upgrade connection probe
justinfrevert fa3ec53
remove logging
justinfrevert bec726a
local env usability fixes
justinfrevert c4add96
Merge branch 'main' into fix/local-env-usability
justinfrevert 98dd8e1
Merge branch 'main' into fix/local-env-usability
justinfrevert a1ea45d
Merge branch 'main' into fix/local-env-usability
justinfrevert 93eeda6
pr review comments
justinfrevert 9b9fc6c
Merge branch 'main' into fix/local-env-usability
justinfrevert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Restore from-genesis bring-up for well-known networks in local-env tooling | ||
|
|
||
| `npm run run:<network> -- --from-genesis` brings up a well-known network's base | ||
| compose from block 0 again, instead of requiring `--from-snapshot` (the genesis | ||
| path was removed together with the internal k8s/AWS integration in #1470). | ||
| Nothing is mocked in this mode: validator seed phrases and a main-chain data | ||
| source must be supplied via `--env-file` or the environment, and the CLI warns | ||
| up front about compose variables left unset and about pre-existing chain data | ||
| directories. | ||
|
|
||
| Also clarifies the fork-network workflow's `node_image`/`new_node_image` inputs | ||
| (full Docker image references with the expected release and CI tag formats, not | ||
| git branches/shas/URLs) and documents how to find snapshot archives for each | ||
| network from the backup system's public index in `docs/fork-testing.md`. | ||
|
|
||
| PR: | ||
| Issue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a clean
--from-genesisrun this starts the base compose file unchanged, but the well-known compose files only passSEED_PHRASE: $MIDNIGHT_NODE_...(for exampledevnet.network.yaml), while the current node only imports validator keys fromAURA_SEED_FILE,GRANDPA_SEED_FILE, andCROSS_CHAIN_SEED_FILEinnode/src/command.rs. As a result, even when users provide the documentedMIDNIGHT_NODE_*_SEEDenv vars, the containers start with empty consensus keystores and the from-genesis network cannot produce/finalize blocks unless stale data already contains keys; this mode needs to generate/mount seed files or update the compose env beforedocker compose up.Useful? React with 👍 / 👎.