ci: background free-disk-space.sh and drop docker prune#1890
Conversation
Signed-off-by: Giles Cope <gilescope@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 596eb19cfe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Free disk space | ||
| if: steps.guard.outputs.hit != 'true' && runner.environment != 'self-hosted' | ||
| run: scripts/free-disk-space.sh | ||
| run: scripts/free-disk-space.sh > /tmp/free-disk-space.log 2>&1 & |
There was a problem hiding this comment.
On GitHub-hosted runners this step now returns immediately, but the next step in this job is the Earthly build (Run pallet fixture tests) that was previously run only after removeUnusedFilesAndDirs had finished reclaiming /opt/hostedtoolcache and other large directories. If the hosted runner is near the disk limit, Earthly can begin pulling/building before that space has actually been freed and fail with ENOSPC; the same backgrounded cleanup pattern was added in the other CI jobs that immediately start disk-heavy builds. Keep the cleanup in the foreground, or explicitly wait for it before the build phase that depends on the reclaimed space.
Useful? React with 👍 / 👎.
1 participant
no need to wait for the disk space to be freed.