Skip to content

test(toolkit): add welcome contract e2e#1898

Open
whankinsiv wants to merge 1 commit into
midnightntwrk:mainfrom
whankinsiv:whankinsiv/migrate-welcome-dapp
Open

test(toolkit): add welcome contract e2e#1898
whankinsiv wants to merge 1 commit into
midnightntwrk:mainfrom
whankinsiv:whankinsiv/migrate-welcome-dapp

Conversation

@whankinsiv

@whankinsiv whankinsiv commented Jul 20, 2026

Copy link
Copy Markdown

Overview

Migrates the welcome example dapp from midnight-contracts as outlined in this plan: https://docs.google.com/spreadsheets/d/1i3cuQpV6ik3kV4tbRZdspK-5unikogaewDCS2gR6I9g/edit?gid=0#gid=0

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • All commits are signed off (git commit -s) for the DCO
  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

NODE_IMAGE=midnightntwrk/midnight-node:2.0.0-rc.4 COMPACT_HOME="$PWD/.compact-home" COMPACTC_VERSION=0.33.0-rc.1 TOOLKIT_JS_PATH="$PWD/util/toolkit-js" cargo test --test toolkit_e2e welcome_e2e

running 1 test
test welcome_e2e has been running for over 60 seconds
test welcome_e2e ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 6 filtered out; finished in 89.03s

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

@whankinsiv
whankinsiv requested a review from a team as a code owner July 20, 2026 22:08
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@datadog-official

datadog-official Bot commented Jul 20, 2026

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 7 Pipeline jobs failed

+audit (cargo deny + npm audit) | audit job npm   View in Datadog   GitHub Actions

+check (format + lint) | Feature Unification Check   View in Datadog   GitHub Actions

+check (format + lint) | Fomatting and Linting   View in Datadog   GitHub Actions

View all 7 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0c0f0d4 | Docs | Give us feedback!

Signed-off-by: William Hankins <william@sundae.fi>
@whankinsiv
whankinsiv force-pushed the whankinsiv/migrate-welcome-dapp branch from 82abc36 to 0c0f0d4 Compare July 20, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant