Fix build on Xcode 16.3 / SDK < 26#359
Merged
Merged
Conversation
Otherwise, the code doesn't compile under Swift strict concurrency.
Collaborator
|
See also #268 -- I thought this was fixed, but I guess not! |
davidkoski
approved these changes
Jun 21, 2026
davidkoski
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the fix, just waiting on CI.
This was referenced Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building MLXVLM on Xcode 16.3 (SDK < 26) fails under Swift strict concurrency because
CIContextis not Sendable. The annotation was added to the macOS 26 SDK. We found this out when bumping mlx-swift-lm to the latest 3.x version in AnyLanguageModel.Proposed changes
Declare the
CIContextvar asnonisolated(unsafe).CIContextrendering ops are actually thread-safe. macOS SDK v6 added an@unchecked Sendableannotation that is not present in previous SDKs.We prepared a test repo that uses GitHub CI to show how builds work with this PR and the official repo, for both Xcode 16.3 and Xcode 26.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes