Validate segmented_mm inner dimensions#3572
Closed
fallintoplace wants to merge 1 commit into
Closed
Conversation
Collaborator
|
This is not how Lines 1295 to 1300 in 2d2d59e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
segmented_mmbefore creating the primitive.MxKandKxNinputs.Why
segmented_mmexpectsato have shapeMxKandbto have shapeKxN, but it did not reject incompatible inner dimensions. This now matches the validation style used by neighboring matmul APIs.Validation
git diff --check HEAD~1..HEADpython3 -m py_compile python/tests/test_blas.pyI could not run the full MLX Python test locally because this machine does not have the Metal compiler available through
xcrun -sdk macosx metal.Fixes #3571