Skip to content

Fix incorrect PAR in qtblend transition #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddennedy merged 2 commits into from
Jul 27, 2026
+0 −10
Merged

Fix incorrect PAR in qtblend transition #1273

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
717c300
Fix qtblend transition incorrect scaling since normalize_mlt_source_s…
j-b-m Jul 24, 2026
4728f3b
Merge branch 'mltframework:master' into work/qtblend-transition-scale
j-b-m Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/modules/qt/transition_qtblend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,6 @@ static int get_image(mlt_frame a_frame,
} else {
transformScale = geometry_dar / b_dar;
}
b_width = *width;
b_height = *height;
}

if (mlt_properties_get(transition_properties, "rect")) {
Expand All @@ -123,10 +121,6 @@ static int get_image(mlt_frame a_frame,
rect.w *= normalized_width;
rect.h *= normalized_height;
}
} else {
// Optimization, request profile sized image
b_width = normalized_width;
b_height = normalized_height;
}
int request_width = *width;
int request_height = *height;
Expand Down Expand Up @@ -162,10 +156,6 @@ static int get_image(mlt_frame a_frame,
// Ensure we don't request an image with a 0 width or height
b_width = qMax(1, b_width);
b_height = qMax(1, b_height);
/*} else {
b_height = *height;
b_width = *width;
}*/

// Normalize source dimensions to consumer PAR to handle anamorphic sources
normalize_mlt_source_size(b_ar, consumer_ar, &b_width, b_height);
Expand Down
Loading