Skip to content

Reject a tool with an invalid x-mcp-header annotation at registration - #3620

Merged
maxisbey merged 2 commits into
mainfrom
3484-reject-invalid-x-mcp-header
Oct 2, 2026
Merged

maxisbey merged 2 commits into
mainfrom
3484-reject-invalid-x-mcp-header

Document header parameters and snapshot the rejection messages

c89d692
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Oct 2, 2026 in 4m 40s

Code review found 1 potential issue

Resolved 2 earlier findings in this review; 0 still open. Found 2 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit tests/docs_src/test_header_parameters.py:91 nit: maintainers get a registered-but-never-invoked tool whose body silently returns 'None', against the repo's test bar