Skip to content

Prepare for CI: Magnetic.FundamentalWave#4789

Open
AHaumer wants to merge 6 commits into
modelica:masterfrom
AHaumer:PrepCI_FW
Open

Prepare for CI: Magnetic.FundamentalWave#4789
AHaumer wants to merge 6 commits into
modelica:masterfrom
AHaumer:PrepCI_FW

Conversation

@AHaumer
Copy link
Copy Markdown
Contributor

@AHaumer AHaumer commented May 20, 2026

Reducing the size of Reference Results
Similar procedure as #4775 and #4787 and #4788

@AHaumer AHaumer added L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave ref-result Issue addresses the reference results labels May 20, 2026
@AHaumer AHaumer marked this pull request as ready for review May 21, 2026 15:12
@AHaumer
Copy link
Copy Markdown
Contributor Author

AHaumer commented May 21, 2026

Now I've worked on 44 examples {Electrical.Machines, Electrical.PowerConverters, Magnetic.FundamentalWave, Magnetic.QuasiStatic.FundamentalWave, Thermal.HeatTransfer} with size of ReferenceResult greater 10 MiB in 4 PRs:
#4775 #4787 #4788 #4789 (this one), reducing the size to 11.3%.
Thanks @maltelenz for updating the annotations in ModelicaTest.
I kindly ask the reviewers to inspect so we can proceed.

I'm unsure whether we could miss a regression:
@henrikt-ma @maltelenz I remember discussions about "extra spikes" in PowerConverters.
The example in MSL compares only two signals over the whole simulation time.
The example in ModelicaTest compares all signals but only over a short time window.

FYI: I'll be off for some time due to health reasons, don't know exactly when I'll be back.

Comment thread ModelicaTest/package.mo Outdated
Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>
@MatthiasBSchaefer
Copy link
Copy Markdown
Contributor

The comparison of the adapted examples of Modelica.Magnetic.FundamentalWave with the existing MAP-LIB-ReferenceResults here:

https://www.ltx.de/download/MA/PR_Testing/PR4789/Modelica/testrun_report.html

and the comparison of the new examples of ModelicaTestMagnetic.FundamentalWave with the existing MAP-LIB-ReferenceResults here:
https://www.ltx.de/download/MA/PR_Testing/PR4789/ModelicaTest/testrun_report.html
Please consider that this is a comparison of new examples inside ModelicaTest with the ReferenceResults of the corresponding MODELICA examples, they are extended from.

Therefore i used a modified CSV-Comparison Tool (modelica-tools/csv-compare#80, modelica-tools/csv-compare#81)

Copy link
Copy Markdown
Contributor

@MatthiasBSchaefer MatthiasBSchaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave ref-result Issue addresses the reference results

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants