test(browser-logs): migrate tests to node:test#3095
Open
bennypowers wants to merge 2 commits into
Open
Conversation
Replace mocha/chai with node:test, node:assert/strict across 1 test file (33 tests). Key changes: - chai expect() -> node:assert/strict - `require.resolve` -> createRequire(import.meta.url) - `__dirname` -> import.meta.dirname - src/ imports -> dist/ imports for native type stripping - `this.timeout()` -> describe timeout option - `(window as any)` -> window['_serialize'] in page.evaluate callbacks to avoid strip-types whitespace shifting Chrome stack trace column numbers - deepEqual with class instances uses spread to plain object since deepStrictEqual checks constructor unlike chai eql - Updated error stack column assertions to match strip-types function serialization format Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
No longer needed after migration to node:assert/strict. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require.resolvewithcreateRequire(import.meta.url)for ESM compatibility__dirnamewithimport.meta.dirname(window as any)._serializewithwindow['_serialize']inpage.evaluatecallbacks to avoid strip-types whitespace shifting Chrome stack trace column numbers{ ...deserialized }spread for class instance deepEqual sincedeepStrictEqualchecks constructor (chaieqldid not)2:29->2:23etc.) to match strip-types function serialization@esm-bundle/chaidevDependencysrc/imports withdist/imports, separate type-only imports withimport typeTest plan