test(dev-server-core): migrate from mocha/chai to node:test#3098
Open
bennypowers wants to merge 3 commits into
Open
test(dev-server-core): migrate from mocha/chai to node:test#3098bennypowers wants to merge 3 commits into
bennypowers wants to merge 3 commits into
Conversation
Replace mocha/chai/hanbi with node:test and node:assert/strict across all 14 test files (97 tests), test helpers, and the published `src/test-helpers.ts` utility. Key changes: - chai `expect` assertions to node:assert/strict - hanbi `stubMethod` to `mock.method` from node:test - `__dirname` to `import.meta.dirname` - Source imports (`../src/`) to dist imports (`../dist/`) - Test-local imports use `.ts` extension for strip-types compat - `context()` to `describe()` (mocha alias not in node:test) - mocha test script to `node --experimental-strip-types --test` Note: `src/test-helpers.ts` is a published utility exported via `exports["./test-helpers"]`. Its `fetchText` function now uses `node:assert` instead of `chai` for the status check -- pending team decision on whether this is acceptable. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 4bef3c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stubMethodwithmock.methodfrom node:testnode --experimental-strip-types --testsrc/test-helpers.tsto use node:assert instead of chai (breaking change, changeset included)Breaking change
src/test-helpers.tsis exported viaexports["./test-helpers"]. ItsfetchTextfunction now throwsnode:assert'sAssertionErrorinstead of chai's on non-200 responses. Functionally identical, different error class. Pending team decision on acceptability.Test plan