test(test-runner): migrate integration tests from mocha/chai to node:test#3099
Open
bennypowers wants to merge 3 commits into
Open
test(test-runner): migrate integration tests from mocha/chai to node:test#3099bennypowers wants to merge 3 commits into
bennypowers wants to merge 3 commits into
Conversation
…test Migrate the shared integration test framework and all three browser launcher test wrappers (chrome, playwright, puppeteer) from mocha/chai to node:test/node:assert/strict. Changes: - integration/test-runner: chai assertions to node:assert, mocha globals to node:test imports, `__dirname` to `import.meta.dirname`, internal imports use .ts extension for strip-types - test-runner-chrome: this.timeout to describe options, src -> dist imports, integration import uses .ts extension - test-runner-playwright: same as chrome - test-runner-puppeteer: same as chrome - All test scripts: mocha -> node --experimental-strip-types --test No published code changes. All packages' src/ directories are untouched. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
integration/test-runner/framework (7 test helper files, 567 lines) from mocha/chai to node:test/node:assert/stricttest-runner-chrome,test-runner-playwright,test-runner-puppeteertest wrappersChanges per component
integration/test-runner/ (shared framework):
__dirnametoimport.meta.dirnamenode --experimental-strip-types --testtest-runner-chrome/playwright/puppeteer (wrappers):
this.timeout(N)todescribe('...', { timeout: N }, () => ...)../src/index.jsto../dist/index.js.tsextensionnode --experimental-strip-types --testNo published code changes
All packages'
src/directories are untouched. Only test files and test scripts changed.Test plan