Skip to content

Feat: system theme live update #6197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
L4stIdi0t wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −9
Open

Feat: system theme live update #6197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1514d7
fix: restore fixed render mode for logs tab
L4stIdi0t May 24, 2026
a8a75e5
feat: react to system theme changes in real time
L4stIdi0t May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/app-frontend/src/routes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ export default new createRouter({
component: Instance.Logs,
meta: {
useRootContext: true,
// renderMode: 'fixed',
renderMode: 'fixed',
breadcrumb: [{ name: '?Instance', link: '/instance/{id}/' }, { name: 'Logs' }],
},
},
Expand Down
19 changes: 11 additions & 8 deletions apps/app-frontend/src/store/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { defineStore } from 'pinia'

let systemThemeMq: MediaQueryList | null = null

export const DEFAULT_FEATURE_FLAGS = {
project_background: false,
page_path: false,
Expand Down Expand Up @@ -49,21 +51,22 @@ export const useTheming = defineStore('themeStore', {
this.setThemeClass()
},
setThemeClass() {
const html = document.getElementsByTagName('html')[0]
for (const theme of THEME_OPTIONS) {
document.getElementsByTagName('html')[0].classList.remove(`${theme}-mode`)
html.classList.remove(`${theme}-mode`)
}

systemThemeMq?.removeEventListener('change', this.setThemeClass)
systemThemeMq = null

let theme = this.selectedTheme
if (this.selectedTheme === 'system') {
const darkThemeMq = window.matchMedia('(prefers-color-scheme: dark)')
if (darkThemeMq.matches) {
theme = 'dark'
} else {
theme = 'light'
}
systemThemeMq = window.matchMedia('(prefers-color-scheme: dark)')
systemThemeMq.addEventListener('change', this.setThemeClass)
theme = systemThemeMq.matches ? 'dark' : 'light'
}

document.getElementsByTagName('html')[0].classList.add(`${theme}-mode`)
html.classList.add(`${theme}-mode`)
},
getFeatureFlag(key: FeatureFlag) {
return this.featureFlags[key] ?? DEFAULT_FEATURE_FLAGS[key]
Expand Down