feat(icons): add ParentItem icon - #3454
Open
korichdaniel wants to merge 1 commit into
Open
Conversation
Add a ParentItem icon for indicating an item's parent in the item hierarchy, complementing the existing Subitems icon. The glyph reuses the Subitems geometry with the parent square filled, so the two icons align when shown together. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTo customize comments, go to the Qodo configuration screen, or learn more in the docs. |
Contributor
PR Summary by QodoAdd ParentItem hierarchy icon to @vibe/icons
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds a
ParentItemicon to@vibe/icons. We need a way to indicate an item's parent in the item hierarchy, which today has no icon — only the child side (Subitems) is covered.Implementation
The glyph is intentionally derived from the existing
Subitems.svgrather than drawn from scratch: the path is identical except that the inner counter of the top-left square is removed, so the parent square renders filled while the subitem square stays outlined.This keeps the two icons pixel-aligned when displayed together — same 20x20 viewBox, same square positions, same stroke thickness and corner radii — and makes the filled/outlined contrast the only signal distinguishing them.
Changes
src/svg/ParentItem.svg- new icon, usingfill="currentColor"per package conventionsrc/iconsMetaData.ts- metadata entry placed next toSubitemssrc/react/ParentItem.tsx,src/react/index.ts- generated byyarn buildTesting
yarn lintpasses, including thevalidate-metaandvalidate-icons-colorschecksyarn buildgenerates the React component, lazy loader, and SVG index exportsSubitemsat multiple sizesMade with Cursor