Skip to content

fix(docs-viewer): fix operator precedence and null safety in AppConta… #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BD-Ali wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(docs-viewer): fix operator precedence and null safety in AppConta… #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions apps/docs-viewer/src/components/app-container/app-container-component.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default class AppContainerComponent extends React.Component {
const { selectedItem, searchTerm } = this.state;
const docs = await getDocs();
const filteredDocs = await getDocs(searchTerm);
const newSelectedItem = selectedItem || docs.length > 0 ? docs[0] : null;
const newSelectedItem = selectedItem || (docs.length > 0 ? docs[0] : null);
this.setState({ docs, filteredDocs, selectedItem: newSelectedItem });
};

Expand All @@ -38,11 +38,12 @@ export default class AppContainerComponent extends React.Component {
};

onRemoveItemClick = async (item) => {
const { selectedItem } = this.state;
const { selectedItem, searchTerm } = this.state;
const docs = await removeDoc(item);
const filteredDocs = await getDocs(searchTerm);

const newState = { docs };
if (item.id === selectedItem.id) newState.selectedItem = docs.length > 0 ? docs[0] : null;
const newState = { docs, filteredDocs };
if (!selectedItem || item.id === selectedItem.id) newState.selectedItem = docs.length > 0 ? docs[0] : null;

this.setState(newState);
};
Expand Down