test: fix flaky CSOT ITERATION cursor timeout tests#4987
Draft
tadjik1 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Increases
timeoutMSin four CSOT ITERATION-mode cursor tests that were intermittently failing on sharded+auth+TLS CI variants.What is the motivation for this change?
Every ITERATION-mode "refreshes the timeout" test works by proving a counter-factual: if the timer were not reset between operations, the cumulative block time would exceed
timeoutMSand the cursor would error.This requires satisfying two constraints simultaneously:
The previous values left only 50 ms of margin per operation (
timeoutMS - blockTimeMS = 50 ms). On fast topologies that is enough; on sharded+auth+TLS every round-trip carries extra overhead (TLS re-use, mongos routing) that regularly pushes an operation past the 50 ms window, causing a flaky timeouts.History: #4278 previously doubled both
blockTimeMSandtimeoutMS(50 to 150 and 100 to 200) but kept the same 50 ms margin, so the underlying problem remained.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript