Skip to content

Remove Electron container support (deprecation) #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bingenito wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove Electron container support (deprecation) #868

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7194136
Remove Electron container support (deprecation)
bingenito Jul 31, 2026
4724757
Regenerate package-lock.json after Electron package removal
bingenito Jul 31, 2026
6282f3d
Merge branch 'main' into security/remove-electron
bingenito Aug 3, 2026
9bbbd1f
Merge branch 'main' into security/remove-electron
bingenito Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 1 addition & 24 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,29 +10,6 @@
"webRoot": "${workspaceRoot}/packages/desktopjs-openfin/dist",
"sourceMaps": true
},
{
"name": "Debug Electron Main",
"type": "node",
"request": "launch",
"cwd": "${workspaceRoot}/examples/web",
"runtimeExecutable": "electron.cmd", // For windows
//"runtimeExecutable": "electron" // Other platforms
"program": "${workspaceRoot}/examples/electron/electron.js"
},
{
"name": "Debug Electron Renderer",
"type": "chrome",
"request": "launch",
"runtimeExecutable": "electron.cmd", // For windows
//"runtimeExecutable": "electron" // Other platforms
"runtimeArgs": [
"${workspaceRoot}/examples/electron",
"--enable-logging",
"--remote-debugging-port=9222"
],
"sourceMaps": true,
"webRoot": "${workspaceRoot}/dist"
},
{
"type": "node",
"request": "launch",
Expand All @@ -44,4 +21,4 @@
"smartStep": true
}
]
}
}
7 changes: 0 additions & 7 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,6 @@ export default [
'license-header/header': ['error', LICENSE_HEADER] // Update the license header rule to use the array
},
},
{
// Override for Electron source file allowing require
files: ['packages/desktopjs-electron/src/electron.ts'],
rules: {
'@typescript-eslint/no-require-imports': 'off'
}
},
{
// Override for spec files
files: ['**/*.spec.ts'],
Expand Down
2 changes: 0 additions & 2 deletions examples/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
[Electron](electron/README.md)

[OpenFin](openfin/README.md)

[Web](web/README.md)
99 changes: 0 additions & 99 deletions examples/electron/README.md
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions examples/electron/electron.js
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions examples/electron/package.json
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions examples/web/assets/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,19 +46,6 @@ desktopJS.Default.DefaultContainerWindow.prototype.getSnapshot = function () {
};
*/

/*
// Provide polyfill for electron notifications. here is an example using electron-notify
desktopJS.Electron.ElectronContainer.prototype.showNotification = function (title, options) {
notifier = (this.isRemote) ? this.electron.require("electron-notify") : require("electron-notify");

notifier.notify({
title: title,
text: options.body,
onClickFunc: function () { options["notification"].onclick(); }
});
};
*/

document.addEventListener("DOMContentLoaded", function (event) {
updatefps();

Expand Down
1 change: 0 additions & 1 deletion examples/web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<title>desktopJS</title>
<script type="text/javascript" src="assets/build/desktop.umd.js"></script>
<script type="text/javascript" src="assets/build/desktopjs-openfin.umd.js"></script>
<script type="text/javascript" src="assets/build/desktopjs-electron.umd.js"></script>

<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap@3.4.1/dist/css/bootstrap.min.css" integrity="sha384-HSMxcRTRxnN+Bdg0JdbxYKrThecOKuH5zCYotlSAcp1+c8xmyTe9GYg1l9a69psu" crossorigin="anonymous">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap@3.4.1/dist/css/bootstrap-theme.min.css" integrity="sha384-6pzBo3FDv/PJ8r2KRkGHifhEocL+1X2rVCTTkUfGk7/0pbek5mMa1upzvWbrUbOZ" crossorigin="anonymous">
Expand Down
Loading