feat: add public Files API methods - #68
Open
HareeshBahuleyan wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The canonical endpoint manifest must classify the newly wrapped Files endpoints as covered.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds public synchronous and asynchronous Files API support to the SDK shell.
Changes:
- Adds upload, list, retrieve, download, and delete methods.
- Uses raw HTTP for multipart uploads and binary downloads.
- Adds documentation and unit coverage.
File summaries
| File | Description |
|---|---|
src/otari/client.py |
Adds synchronous Files API methods. |
src/otari/async_client.py |
Adds asynchronous Files API methods. |
tests/unit/test_client.py |
Tests synchronous file operations. |
tests/unit/test_async_client.py |
Tests asynchronous file operations. |
README.md |
Documents Files API usage. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The gateway Files API exists, but callers have to reach into the generated client because the supported SDK shell does not expose it.
What changed
Added sync and async methods to upload, list, retrieve, download, and delete files. Multipart uploads and binary downloads use raw HTTP transport, with SDK error mapping, documentation, and unit coverage.
Notes
gpt-5.6-sol.Ref: mozilla-ai/otari#177