Skip to content

feat: add public Files API methods - #68

Open
HareeshBahuleyan wants to merge 1 commit into
mainfrom
feat/files-api-wrappers
Open

feat: add public Files API methods#68
HareeshBahuleyan wants to merge 1 commit into
mainfrom
feat/files-api-wrappers

Conversation

@HareeshBahuleyan

Copy link
Copy Markdown
Contributor

Why

The gateway Files API exists, but callers have to reach into the generated client because the supported SDK shell does not expose it.

What changed

Added sync and async methods to upload, list, retrieve, download, and delete files. Multipart uploads and binary downloads use raw HTTP transport, with SDK error mapping, documentation, and unit coverage.

Notes

  • The Files API is currently available on standalone Otari gateways.
  • Verified with 150 passing tests, Ruff, strict mypy, and package builds on Python 3.12.
  • Implemented with Pi using OpenAI gpt-5.6-sol.

Ref: mozilla-ai/otari#177

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The canonical endpoint manifest must classify the newly wrapped Files endpoints as covered.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds public synchronous and asynchronous Files API support to the SDK shell.

Changes:

  • Adds upload, list, retrieve, download, and delete methods.
  • Uses raw HTTP for multipart uploads and binary downloads.
  • Adds documentation and unit coverage.
File summaries
File Description
src/otari/client.py Adds synchronous Files API methods.
src/otari/async_client.py Adds asynchronous Files API methods.
tests/unit/test_client.py Tests synchronous file operations.
tests/unit/test_async_client.py Tests asynchronous file operations.
README.md Documents Files API usage.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/otari/client.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants