Skip to content

Remove public OAuth API, direct to go through state machine#7395

Open
skhamis wants to merge 1 commit into
mozilla:mainfrom
skhamis:remove-public-oauth
Open

Remove public OAuth API, direct to go through state machine#7395
skhamis wants to merge 1 commit into
mozilla:mainfrom
skhamis:remove-public-oauth

Conversation

@skhamis
Copy link
Copy Markdown
Contributor

@skhamis skhamis commented Jun 3, 2026

Now that firefox-ios is using the state machine, we can remove these methods as they might cause confusion in the future for anything looking for how to start a FxA sign in process. Instead they should go through the state machine which will reduce complexity and reduce fxa-state-related issues.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@skhamis skhamis requested review from bendk and mhammond June 3, 2026 21:12
Copy link
Copy Markdown
Member

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants