Skip to content

WIP: test logins update behaviour bumps usage stamps#7398

Open
jo wants to merge 1 commit into
mozilla:mainfrom
jo:bug-2045032
Open

WIP: test logins update behaviour bumps usage stamps#7398
jo wants to merge 1 commit into
mozilla:mainfrom
jo:bug-2045032

Conversation

@jo
Copy link
Copy Markdown
Contributor

@jo jo commented Jun 4, 2026

Checking regarding the breakability of this change:

  • Android records password use via touch() and uses update() only for explicit edits
  • iOS too

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@jo jo force-pushed the bug-2045032 branch 2 times, most recently from ce751b3 to 8cf2535 Compare June 4, 2026 15:58
Login's `update()` incremented `times_used` and set `time_last_used`
on every edit. Only touch() should update those fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant