Skip to content

Bug 2057561 - Caching derived scatter data (Fix 2) #9750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidmiculit wants to merge 1 commit into
base: master
Choose a base branch
from
+50 −22
Open

Bug 2057561 - Caching derived scatter data (Fix 2) #9750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 50 additions & 22 deletions ui/perfherder/graphs/GraphsContainer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,6 @@ class GraphsContainer extends React.Component {
timeRange,
selectedDataPoint,
} = this.props;
const _scatterPlotData = flatMap(testData, (item) =>
item.visible ? item.data : [],
);

if (
prevProps.highlightAlerts !== highlightAlerts ||
Expand Down Expand Up @@ -390,6 +387,55 @@ class GraphsContainer extends React.Component {
return data.reduce((max, p) => (p.y > max ? p.y : max), data[0].y);
};

_dataKey = (props) => {

@esanuandra esanuandra Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are they named with _ ?

const testDataSig = (props.testData || [])
.map((t) => `${t.signature_id}:${t.visible}`)
.join(',');

return `${testDataSig}|${props.timeRange?.value}|${props.changelogData?.length}`;
};

_getMemoizedData = () => {
const currentKey = this._dataKey(this.props);

if (currentKey === this._lastKey) {
return {
scatterPlotData: this._scatterCache,
infraAffectedData: this._infraAffectedCache,
};
}

const scatterPlotData = (this.props.testData || []).flatMap((item) =>
item.visible ? item.data : [],
);

let rawInfraData = [];
const markDataPoints = 5;

(this.props.changelogData || []).forEach((data) =>
scatterPlotData.some((dataPoint, index) => {
const affectedData = dataPoint.x > data.date;
if (affectedData) {
rawInfraData.push(
scatterPlotData.slice(index, index + markDataPoints),
);
}
return affectedData;
}),
);

this._scatterCache = scatterPlotData;
this._infraAffectedCache = new Set(
flatMap(rawInfraData).map((item) => item.revision),
);
this._lastKey = currentKey;

return {
scatterPlotData: this._scatterCache,
infraAffectedData: this._infraAffectedCache,
};
};

render() {
const {
testData = [],
Expand All @@ -405,36 +451,18 @@ class GraphsContainer extends React.Component {
const {
highlights,
highlightCommonAlertsData,
scatterPlotData,
zoomDomain,
width,
} = this.state;

let infraAffectedData = [];
const markDataPoints = 5;
const { scatterPlotData, infraAffectedData } = this._getMemoizedData();
const hoverDatum = this.state.hoverId
? scatterPlotData.find((d) => d?.dataPointId === this.state.hoverId)
: null;
const lockedDatum = this.state.lockedId
? scatterPlotData.find((d) => d?.dataPointId === this.state.lockedId)
: null;

changelogData.forEach((data) =>
scatterPlotData.some((dataPoint, index) => {
const affectedData = dataPoint.x > data.date;
if (affectedData) {
infraAffectedData.push(
scatterPlotData.slice(index, index + markDataPoints),
);
}
return affectedData;
}),
);

infraAffectedData = new Set(
flatMap(infraAffectedData).map((item) => item.revision),
);

const yAxisLabel = this.computeYAxisLabel();
const positionedTick = <VictoryLabel dx={-2} />;
const positionedLabel = <VictoryLabel dy={24} />;
Expand Down