Skip to content

Refactor countdown logic #9759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beatrice-acasandrei wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Refactor countdown logic #9759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
776755b
fix: change the entire logic for getting the remaining time until Due
davidmiculit Jul 17, 2026
70b065d
feat: add exact due date in the clock tooltip
davidmiculit Jul 17, 2026
26fad2e
test: change old tooltip text to new one
davidmiculit Jul 17, 2026
40f6b0e
test: change all tests to match the new text and logic
davidmiculit Jul 17, 2026
c971894
test: test working fine, but date not being set correctly
davidmiculit Jul 17, 2026
c976895
WIP
beatrice-acasandrei Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 27 additions & 27 deletions tests/ui/perfherder/alerts-view/alert_status_countdown_test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ test('Alert is created on Monday, Triage countdown shows 3 working days', async

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Triage: 3 days left');
expect(dueDateStatusText).toBe('Time left: 3 days left');
});

test('Alert is created on Monday, Triage countdown shows 2 working days', async () => {
Expand All @@ -62,7 +62,7 @@ test('Alert is created on Monday, Triage countdown shows 2 working days', async

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Triage: 2 days left');
expect(dueDateStatusText).toBe('Time left: 2 days left');
});

test('Alert is created on Monday, Triage countdown shows 1 working days', async () => {
Expand All @@ -82,7 +82,7 @@ test('Alert is created on Monday, Triage countdown shows 1 working days', async

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Triage: 1 days left');
expect(dueDateStatusText).toBe('Time left: 1 days left');
});

test('Alert is created on Monday, Triage countdown shows hours left', async () => {
Expand All @@ -102,7 +102,7 @@ test('Alert is created on Monday, Triage countdown shows hours left', async () =

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Triage: 10 hours left');
expect(dueDateStatusText).toBe('Time left: 10 hours left');
});

test('Alert is created on Monday, Triage countdown shows Overdue', async () => {
Expand All @@ -122,7 +122,7 @@ test('Alert is created on Monday, Triage countdown shows Overdue', async () => {

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Triage: Overdue');
expect(dueDateStatusText).toBe('Time left: Overdue');
});

test('Alert is created on Monday, Bug countdown shows 5 working days', async () => {
Expand All @@ -143,7 +143,7 @@ test('Alert is created on Monday, Bug countdown shows 5 working days', async ()

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: 5 days left');
expect(dueDateStatusText).toBe('Time left: 5 days left');
});

test('Alert is created on Monday, Bug countdown shows 4 working days', async () => {
Expand All @@ -164,7 +164,7 @@ test('Alert is created on Monday, Bug countdown shows 4 working days', async ()

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: 4 days left');
expect(dueDateStatusText).toBe('Time left: 4 days left');
});

test('Alert is created on Monday, Bug countdown shows 3 working days', async () => {
Expand All @@ -185,7 +185,7 @@ test('Alert is created on Monday, Bug countdown shows 3 working days', async ()

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: 3 days left');
expect(dueDateStatusText).toBe('Time left: 3 days left');
});

test('Alert is created on Monday, Bug countdown shows 2 working days', async () => {
Expand All @@ -206,7 +206,7 @@ test('Alert is created on Monday, Bug countdown shows 2 working days', async ()

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: 2 days left');
expect(dueDateStatusText).toBe('Time left: 2 days left');
});

test('Alert is created on Monday, Bug countdown shows 1 working days', async () => {
Expand All @@ -227,7 +227,7 @@ test('Alert is created on Monday, Bug countdown shows 1 working days', async ()

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: 1 days left');
expect(dueDateStatusText).toBe('Time left: 1 days left');
});

test('Alert is created on Monday, Bug countdown shows hours left', async () => {
Expand All @@ -248,7 +248,7 @@ test('Alert is created on Monday, Bug countdown shows hours left', async () => {

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: 23 hours left');
expect(dueDateStatusText).toBe('Time left: 23 hours left');
});

test('Alert is created on Monday, Bug countdown shows Overdue', async () => {
Expand All @@ -269,7 +269,7 @@ test('Alert is created on Monday, Bug countdown shows Overdue', async () => {

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: Overdue');
expect(dueDateStatusText).toBe('Time left: Overdue');
});

// testing what the tooltip shows for the cases when the alert is created either on Wednesday, Thursday, Friday or the weekend
Expand All @@ -293,7 +293,7 @@ test('Alert is created on Wednesday, Triage countdown shows 3 working days', asy

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Triage: 3 days left');
expect(dueDateStatusText).toBe('Time left: 3 days left');
});

test('Alert is created on Wednesday, Triage countdown shows 2 working days', async () => {
Expand All @@ -314,7 +314,7 @@ test('Alert is created on Wednesday, Triage countdown shows 2 working days', asy

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Triage: 2 days left');
expect(dueDateStatusText).toBe('Time left: 2 days left');
});

test('Alert is created on Wednesday, Triage countdown shows 1 working days', async () => {
Expand All @@ -335,10 +335,10 @@ test('Alert is created on Wednesday, Triage countdown shows 1 working days', asy

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Triage: 1 days left');
expect(dueDateStatusText).toBe('Time left: 1 days left');
});

test('Alert is created on Wednesday, Triage countdown shows hours left', async () => {
test('Alert is created on Wednesday, Triage countdown shows Overdue when due date has been reached', async () => {
const alert = testAlertSummaries[0];

// created date day is set to Wednesday
Expand All @@ -356,7 +356,7 @@ test('Alert is created on Wednesday, Triage countdown shows hours left', async (

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Triage: 0 hours left');
expect(dueDateStatusText).toBe('Time left: Overdue');
});

test('Alert is created on Wednesday, Triage countdown shows Overdue', async () => {
Expand All @@ -377,7 +377,7 @@ test('Alert is created on Wednesday, Triage countdown shows Overdue', async () =

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Triage: Overdue');
expect(dueDateStatusText).toBe('Time left: Overdue');
});

test('Alert is created on Wednesday, Bug countdown shows 5 working days', async () => {
Expand All @@ -398,7 +398,7 @@ test('Alert is created on Wednesday, Bug countdown shows 5 working days', async

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: 5 days left');
expect(dueDateStatusText).toBe('Time left: 5 days left');
});

test('Alert is created on Wednesday, Bug countdown shows 4 working days', async () => {
Expand All @@ -419,7 +419,7 @@ test('Alert is created on Wednesday, Bug countdown shows 4 working days', async

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: 4 days left');
expect(dueDateStatusText).toBe('Time left: 4 days left');
});

test('Alert is created on Wednesday, Bug countdown shows 3 working days', async () => {
Expand All @@ -440,7 +440,7 @@ test('Alert is created on Wednesday, Bug countdown shows 3 working days', async

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: 3 days left');
expect(dueDateStatusText).toBe('Time left: 3 days left');
});

test('Alert is created on Wednesday, Bug countdown shows 2 working days', async () => {
Expand All @@ -461,7 +461,7 @@ test('Alert is created on Wednesday, Bug countdown shows 2 working days', async

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: 2 days left');
expect(dueDateStatusText).toBe('Time left: 2 days left');
});

test('Alert is created on Wednesday, Bug countdown shows 1 working days', async () => {
Expand All @@ -482,7 +482,7 @@ test('Alert is created on Wednesday, Bug countdown shows 1 working days', async

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: 1 days left');
expect(dueDateStatusText).toBe('Time left: 1 days left');
});

test('Alert is created on Wednesday, Bug countdown shows hours left', async () => {
Expand All @@ -491,10 +491,10 @@ test('Alert is created on Wednesday, Bug countdown shows hours left', async () =
// created date day is set to Wednesday
alert.created = '2022-02-09T11:41:31.419156';
alert.first_triaged = '2022-02-09T11:41:31.419156';
alert.bug_due_date = '2022-02-16T10:41:31.419156';
alert.bug_due_date = '2022-02-16T12:41:31.419156';

// current day is set to Wednesday
Date.now = jest.fn(() => Date.parse('2022-02-16T12:40:31.419156'));
Date.now = jest.fn(() => Date.parse('2022-02-16T10:41:31.419156'));

const { getByTestId } = testStatusDropdown([], alert);
const dueDateIcon = await waitFor(() => getByTestId('triage-clock-icon'));
Expand All @@ -503,7 +503,7 @@ test('Alert is created on Wednesday, Bug countdown shows hours left', async () =

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: 2 hours left');
expect(dueDateStatusText).toBe('Time left: 2 hours left');
});

test('Alert is created on Wednesday, Bug countdown shows Overdue', async () => {
Expand All @@ -524,7 +524,7 @@ test('Alert is created on Wednesday, Bug countdown shows Overdue', async () => {

const dueDateStatus = await waitFor(() => getByTestId('due-date-status'));
const dueDateStatusText = dueDateStatus.querySelector('p').innerHTML;
expect(dueDateStatusText).toBe('Bug: Overdue');
expect(dueDateStatusText).toBe('Time left: Overdue');
});

test('Alert is ready, countdown shows Ready for acknowledge', async () => {
Expand Down
Loading