-
-
Notifications
You must be signed in to change notification settings - Fork 36.3k
WebGPURenderer: Surface uncaptured GPU errors and WGSL diagnostics #33418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RenaudRohlinger
wants to merge
5
commits into
mrdoob:dev
Choose a base branch
from
RenaudRohlinger:renaud/webgpu-error-reporting
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+144
−10
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e99a922
WebGPURenderer: Surface uncaptured errors and shader compilation diag…
RenaudRohlinger e14db81
WebGPURenderer: Move diagnostic safety into the helper itself.
RenaudRohlinger 07ff290
WebGPURenderer: Tighten error-reporting helpers.
RenaudRohlinger baf27d9
Merge remote-tracking branch 'upstream/dev' into renaud/webgpu-error-…
RenaudRohlinger a918564
WebGPURenderer: Trim defensive guards in shader diagnostics helper.
RenaudRohlinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes, for me, LLMs add many extra checks; could that be the case? Maybe the info checks bellow is also overloaded with verification?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I went back through and most of them were paranoia rather than real protection.
The module check, the try/catch around
getCompilationInfo(), the!info || !info.messagesguards, all of those are covered by the WebGPU spec already.getCompilationInfo()is a mandatory method onGPUShaderModuleand it resolves to aGPUCompilationInfowith a non-nullmessagesarray; it doesn't reject. Same forprogramandprogram.code, the caller always passes a realProgrammableStage, so guarding those was just noise.The only thing I kept (in a slightly different form) is the bounds check on
sourceLines[lineNum - 1]: I swapped theline !== undefinedcheck formsg.lineNum <= sourceLines.length, which reads more clearly as "is the compiler pointing at a line we actually have."Once all that came out, the outer
try/catchswallow-all didn't have anything left to catch, so I dropped it (and the long "best-effort, never propagates" docstring that was justifying it).Helper went from ~85 lines to ~30, same output in any spec-compliant browser. Pushed as a918564.