Skip to content

UniformsGroup: Pool per-uniform update-range objects. #33427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mugen87 merged 2 commits into from
Apr 21, 2026
+20 −9
Merged

UniformsGroup: Pool per-uniform update-range objects. #33427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
120faef
UniformsGroup: Pool per-uniform update-range objects.
RenaudRohlinger Apr 20, 2026
beba1b1
UniformsGroup: Track pushed indices in a Set, keep range objects pure.
RenaudRohlinger Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions src/renderers/common/UniformsGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,15 @@ class UniformsGroup extends UniformBuffer {
*/
this._updateRangeCache = new Map();

/**
* Uniform indices whose range has already been pushed into `updateRanges`
* during the current update cycle. Reset on `clearUpdateRanges()`.
*
* @private
* @type {Set<number>}
*/
this._addedIndices = new Set();

}

/**
Expand All @@ -66,29 +75,31 @@ class UniformsGroup extends UniformBuffer {

const index = uniform.index;

if ( this._updateRangeCache.has( index ) !== true ) {
if ( this._addedIndices.has( index ) ) return;

const updateRanges = this.updateRanges;
let range = this._updateRangeCache.get( index );

const start = uniform.offset;
const count = uniform.itemSize;

const range = { start, count };

updateRanges.push( range );
if ( range === undefined ) {

range = { start: 0, count: 0 };
this._updateRangeCache.set( index, range );

}

range.start = uniform.offset;
range.count = uniform.itemSize;

this._addedIndices.add( index );
this.updateRanges.push( range );

}

/**
* Clears all update ranges of this buffer.
*/
clearUpdateRanges() {

this._updateRangeCache.clear();
this._addedIndices.clear();

super.clearUpdateRanges();

Expand Down
Loading