WebGPURenderer ColorNode: test adding color clamp before premultiply#33437
WebGPURenderer ColorNode: test adding color clamp before premultiply#33437gkjohnson wants to merge 2 commits intomrdoob:devfrom
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
Here are the failing WebGPU tests compared to #33329: 22 failing testsE2E 3
E2E 4
So it's down 34 to 22 (12 tests fixed). However it seems there are some new tests failing, too, (marked with an asterisk above) though it's not clear to me how reliable the tests are at the moment since WebGLRenderer tests are now also failing. @Mugen87 do you have any thoughts on what might be causing these webgl renderer test failures? I've rerun the E2E 0 test batch several times now. |
Some of the "misc" examples already use |
Thanks - I didn't realize that. I've gone through all the 22 above failing examples and aside from the following four I'm seeing that they all use transparent background so the CSS background color should show through and failures are expected. We'll need to replace those screenshots. The following examples have other issues that seem to be indicative of some other blending or multiplication issues elsewhere in WebGPURenderer. I'll have to leave this to someone else who's more familiar with these demos and material definitions. Aside from the following 4 it seems that the other examples fall into a failure case of the final image having an alpha value outside of [0, 1] (as outlined in #33329 (comment)) or they are valid failures because the examples are deliberately using a transparent background on the canvas. webgpu_mesh_batchThis example sets a clear color with 1.0 alpha but for some reason the CSS background color shows through some shaded areas of the objects.
webgpu_postprocessing_sobelThe failure in this case is not clear to me since the sobel effect seems to be displayed as 1.0 alpha across the image so this needs more investigation. webgpu_postprocessing_pixelThe accented edges of the effect seem to be returned with a < 1.0 alpha resulting in the css background showing through.
webgpu_postprocessing_motion_blurThe vignette effect applied to the demo seems to multiply into the alpha channel, as well, resulting in the CSS color affecting the image (and will also therefore be impacted by the blending color space).
cc @WestLangley |






In parallel with #33329
Related to #33329 (comment)
Description
Submission of #33329 with additional alpha clamp before un-premultiply to test how many tests continue to fail.
34 failing tests in #33329
E2E 3
E2E 4