Skip to content

Fix examples to avoid fading alpha #33450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mugen87 merged 2 commits into from
Apr 23, 2026
+9 −6
Merged

Fix examples to avoid fading alpha #33450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a82f30e
Fix examples to avoid fading alpha
gkjohnson Apr 23, 2026
1054b80
Add missing rgb
gkjohnson Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/jsm/tsl/display/PixelationPassNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { NearestFilter, Vector4, TempNode, NodeUpdateType, PassNode } from 'three/webgpu';
import { nodeObject, Fn, float, uv, uniform, convertToTexture, vec2, vec3, clamp, floor, dot, smoothstep, If, sign, step, mrt, output, normalView, property } from 'three/tsl';
import { nodeObject, Fn, float, uv, uniform, convertToTexture, vec2, vec3, clamp, floor, dot, smoothstep, If, sign, step, mrt, output, normalView, property, vec4 } from 'three/tsl';

/**
* A inner node definition that implements the actual pixelation TSL code.
Expand Down Expand Up @@ -202,7 +202,7 @@ class PixelationNode extends TempNode {

const strength = dei.greaterThan( 0 ).select( float( 1.0 ).sub( dei.mul( this.depthEdgeStrength ) ), nei.mul( this.normalEdgeStrength ).add( 1 ) );

return texel.mul( strength );
return vec4( texel.mul( strength ).rgb, texel.a );

} );

Expand Down
7 changes: 5 additions & 2 deletions examples/webgpu_mesh_batch.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
import { OrbitControls } from 'three/addons/controls/OrbitControls.js';
import { radixSort } from 'three/addons/utils/SortUtils.js';

import { normalView, directionToColor, diffuseColor } from 'three/tsl';
import { normalView, directionToColor, diffuseColor, vec4 } from 'three/tsl';

let camera, scene, renderer;
let controls;
Expand Down Expand Up @@ -126,7 +126,10 @@
if ( ! material ) {

material = new THREE.MeshBasicNodeMaterial();
material.outputNode = diffuseColor.mul( directionToColor( normalView ).y.add( 0.5 ) );
material.outputNode = vec4(
diffuseColor.mul( directionToColor( normalView ).y.add( 0.5 ) ).rgb,
diffuseColor.a,
);

}

Expand Down
4 changes: 2 additions & 2 deletions examples/webgpu_postprocessing_motion_blur.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<script type="module">

import * as THREE from 'three/webgpu';
import { pass, texture, uniform, output, mrt, velocity, uv, screenUV } from 'three/tsl';
import { pass, texture, uniform, output, mrt, velocity, uv, screenUV, vec4 } from 'three/tsl';
import { motionBlur } from 'three/addons/tsl/display/MotionBlur.js';

import { GLTFLoader } from 'three/addons/loaders/GLTFLoader.js';
Expand Down Expand Up @@ -194,7 +194,7 @@
const vignette = screenUV.distance( .5 ).remap( .6, 1 ).mul( 2 ).clamp().oneMinus();

renderPipeline = new THREE.RenderPipeline( renderer );
renderPipeline.outputNode = mBlur.mul( vignette );
renderPipeline.outputNode = vec4( mBlur.mul( vignette ).rgb, mBlur.a );

//

Expand Down
Loading