Repository navigation
fix: rename Error to AsyncError in ObjC/Swift export - #52
Merged
Merged
Conversation
Add @ObjCName annotations to avoid name collisions with Swift.Error when using the library from iOS/Swift: - Error class → AsyncError - ErrorId value class → AsyncErrorId - ErrorWithMetadata function → AsyncErrorWithMetadata - ErrorWithId function → AsyncErrorWithId This is a non-breaking change for Kotlin consumers.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
@ObjCNameannotations to avoid name collisions withSwift.Errorwhen using the library from iOS/Swift.Changes
Errorclass →AsyncErrorErrorIdvalue class →AsyncErrorIdErrorWithMetadatafunction →AsyncErrorWithMetadataErrorWithIdfunction →AsyncErrorWithIdNotes
This is a non-breaking change for Kotlin consumers. The annotations only affect the ObjC/Swift interop layer.
Uses
@OptIn(ExperimentalObjCName::class)at file level since the annotation is still experimental in Kotlin 2.x.