Bugfix/metadataparser integer overflow - #1044
Open
gongyixiao wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for cmotempo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In most cases, R's integer data type is implemented as a 32-bit signed integer. This means the range of numbers it can represent is limited:
Minimum value: −2e31 (which is -2,147,483,648)
Maximum value: 2e31−1 (which is 2,147,483,647)
This solution is complicated because the docker image it is using is a very old version R-3.3.2, and the
lib64package need to be installed as a specific version to the R version.I'm avoiding to rebuild the docker image, i'm installing the packages in the actual Rscript. We may rebuild the docker image and consolidate a more recent version for R and Python processes in the pipeline when we get to the point to host the image in JFrog.
Note: This PR replaces #1039 which was automatically closed due to repository history cleanup.