Simplified target/bait inputs - #970
Open
anoronh4 wants to merge 5 commits into
Open
Conversation
✅ Deploy Preview for cmotempo canceled.
|
gongyixiao
approved these changes
Apr 18, 2024
gongyixiao
left a comment
Collaborator
There was a problem hiding this comment.
I agree this is indeed simplifying the process. But I guess there might be some additional conflicts resolving involved regarding placeHolder values and storeDir.
Collaborator
✅ Deploy Preview for cmotempo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we have required several tempo files to be generated for each baitset. The processes for generating files such as the coding bed, the intervals list, etc, were not well-documented or formalized, which presents a problem for ease of use and standardization. This PR aims to simplify that process by only requiring the
targets.bedandbaits.bedand creating the other necessary files within Tempo with a new process.