Skip to content

Make autocrafter take items from last stack first #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OgelGames merged 2 commits into from
Aug 15, 2026
Merged

Make autocrafter take items from last stack first #221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c241460
make autocrafter take items from last stack first
OgelGames Aug 12, 2026
d24f932
spaces and other formatting fixes
OgelGames Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 25 additions & 21 deletions autocrafter.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

local S = core.get_translator("pipeworks")
local fs_helpers = pipeworks.fs_helpers
local has_digilines = core.get_modpath("digilines")
Expand All @@ -19,7 +18,7 @@ local group_index = {}

-- Turns any list of items or groups into a list of nine itemstacks
local function normalize_items(items)
for i=1, 9 do
for i = 1, 9 do
local item = items[i]
local t = type(item)
if t == "string" then
Expand Down Expand Up @@ -50,7 +49,7 @@ local function stack_items(items)
item = stack:add_item(item)
end
if not item:is_empty() then
stacked[#stacked+1] = item
stacked[#stacked + 1] = item
end
end
return stacked
Expand All @@ -61,7 +60,7 @@ local function add_to_list(list, stack)
local empty = {}
for _,s in ipairs(list) do
if s:is_empty() then
empty[#empty+1] = s
empty[#empty + 1] = s
else
stack = s:add_item(stack)
if stack:is_empty() then
Expand Down Expand Up @@ -153,9 +152,9 @@ local function get_craft_result(items, fake_player)
for _,stack in ipairs(fake_inv:get_list("craft")) do
if not stack:is_empty() then
if recipe_items[stack:get_name()] then
replacements[#replacements+1] = stack
replacements[#replacements + 1] = stack
else
outputs[#outputs+1] = stack
outputs[#outputs + 1] = stack
end
end
end
Expand Down Expand Up @@ -214,7 +213,7 @@ local function set_craft_by_output(pos, output)
-- Avoid dyeing/repairing recipes
score = 0 ; break
elseif item:sub(1, 6) == "group:" then
-- Recipes that use groups are better
-- Recipes that use groups are better
score = score + 1
elseif not core.registered_items[item] then
-- Never use a recipe with an unknown item
Expand All @@ -239,9 +238,11 @@ end

local function get_ingredients(src, recipe)
local items = {}
for i, stack in ipairs(src) do
-- Work backwards to avoid creating gaps or partial stacks
for i = #src, 1, -1 do
local stack = src[i]
if not stack:is_empty() then
items[i] = stack:get_name()
items[#items + 1] = {stack = stack, name = stack:get_name()}
end
end
local ingredients = {}
Expand All @@ -255,11 +256,12 @@ local function get_ingredients(src, recipe)
if group and group_index[group] then
match_items = group_index[group].items
end
for j, name in pairs(items) do
if match_items[name] then
ingredients[i] = src[j]:take_item()
if src[j]:is_empty() then
items[j] = nil
for j, item in ipairs(items) do
if match_items[item.name] then
ingredients[i] = item.stack:take_item()
if item.stack:is_empty() then
-- Need to use `table.remove` to not break subsequent iterations
table.remove(items, j)
end
found = true ; break
end
Expand Down Expand Up @@ -468,7 +470,7 @@ local function can_insert_stack(pos, stack)
end
end
-- Loop backwards to find empty slots quicker
for i=#src, 1, -1 do
for i = #src, 1, -1 do
local item = src[i]
if item:is_empty() then
empty = empty + 1
Expand Down Expand Up @@ -528,10 +530,10 @@ local function format_recipe(list)
local slot = y * 3 + x
local item = list[slot]
item = item:get_meta():get("group") or item:get_name()
row[#row+1] = item
row[#row + 1] = item
items[slot] = item ~= "" and item or nil
end
recipe[#recipe+1] = row
recipe[#recipe + 1] = row
end
return recipe, items
end
Expand Down Expand Up @@ -563,10 +565,12 @@ local function digilines_action(pos, _, channel, msg)
if msg.command == "get" then
local recipe, input = format_recipe(inv:get_list("recipe"))
local output = inv:get_stack("output", 1)
local keep_items = ({"none", "replacements", "all"})[meta:get_int("keep_items")+1]
local keep_items = ({"none", "replacements", "all"})[meta:get_int("keep_items") + 1]
digilines.receptor_send(pos, digilines.rules.default, channel, {
recipe = recipe, input = input,
result = output:to_table(), output = output:get_name(),
recipe = recipe,
result = output:to_table(),
input = input,
output = output:get_name(),
keep_items = keep_items,
active = meta:get_int("enabled") == 1,
})
Expand Down Expand Up @@ -732,7 +736,7 @@ core.register_node("pipeworks:autocrafter", {
start_autocrafter(pos)
end
end,
on_metadata_inventory_put = function(pos, list, index, stack, player)
on_metadata_inventory_put = function(pos, list, index, stack, player)
if list == "src" then
start_autocrafter(pos)
end
Expand Down