fix(youtube-video-element): clipboard-write & web-share added#248
Open
jeffsawyer wants to merge 1 commit into
Open
fix(youtube-video-element): clipboard-write & web-share added#248jeffsawyer wants to merge 1 commit into
jeffsawyer wants to merge 1 commit into
Conversation
Aligns the embed iframe's `allow` attribute with YouTube's official embed so the in-player Share / Copy-link controls can use the Clipboard and Web Share APIs. Fixes muxinc#247
|
@jeffsawyer is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the embed iframe's
allowattribute with YouTube's official embed so the in-player Share / Copy-link controls can use the Clipboard and Web Share APIs.Fixes #247
Note: might be worth making this configurable in a future update similar to other features
Note
Low Risk
Single iframe permission string change with no auth, data, or playback logic touched.
Overview
Extends the YouTube embed iframe
allowlist withclipboard-writeandweb-shareso in-player Share and copy link controls can use the Clipboard and Web Share APIs, matching YouTube’s official embed behavior (fixes #247).No other embed packages or player logic are changed in this diff.
Reviewed by Cursor Bugbot for commit 8fe3a1f. Bugbot is set up for automated code reviews on this repo. Configure here.