Address feedback: add $wgCrawlerProtectionProtectRevisions to independently control revision/diff blocking#32
Merged
jeffw16 merged 2 commits intoJun 19, 2026
Conversation
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on history-related blocking for $wgCrawlerProtectedActions
Address feedback: add Jun 18, 2026
$wgCrawlerProtectionProtectRevisions to independently control revision/diff blocking
jeffw16
approved these changes
Jun 19, 2026
jeffw16
merged commit a181220
into
copilot/fix-crawler-protection-history
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the feedback on #30. I've created this new PR, which merges into #30, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.
Original PR: #30
Triggering review: #30 (review)
Changes Made
$wgCrawlerProtectionProtectRevisions(defaulttrue): whentrue, anonymous access to individual revisions and diffs (type=revision,diff=,oldid=query parameters) is denied; whenfalse, those requests are allowed. This control is fully independent of$wgCrawlerProtectedActions, so operators can protect revisions/diffs without protecting the history-listing page, or vice versa.CrawlerProtectionService: replaced the old logic that gated revision/diff blocking on'history'being present inCrawlerProtectedActionswith a direct read of the newCrawlerProtectionProtectRevisionsconfig key.buildService()helper to accept a$protectRevisionsparameter; updated the existing "allows history-related when not configured" test; added new test cases covering all cross-combinations of the two independent controls.$wgCrawlerProtectedActionsand the new$wgCrawlerProtectionProtectRevisionsvariable.