Potential fix for #272#273
Open
TMRh20 wants to merge 1 commit into
Open
Conversation
2bndy5
reviewed
Jul 15, 2026
Member
There was a problem hiding this comment.
Makes sense in the sense that each platform allocates different sizes for data types. We've certainly seen divergences in ESP cores on this numerous times before. I suspect this sizeof(Header) + sizeof(Addr) math is done at compile time. Might be cleaner to have a constexpr to signify that this math is calculating the... whatchamacallit... FRAG_MSG_OFFSET?
Member
Author
There was a problem hiding this comment.
Yeah, if this works, we can def do that
Member
Author
|
Been 6 days running w/no problems, going to give it a while longer: ***********Reset reason************: External System
Free: 31952 | Max Block: 31632 | Frag: 2%Memory is holding steady and functionality is right on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran the reassembly code through AI again and it came up with these code changes. Currently testing...