Skip to content

test(feedback): allow retry fixture to finish (#759) #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kewe63 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test(feedback): allow retry fixture to finish (#759) #761

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbbac73
test(feedback): allow retry fixture to finish
Kewe63 Oct 22, 2026
dadaec8
ci: retry native auth matrix
Kewe63 Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/__tests__/feedback.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import { memoryOperation, sessionFixture } from './fixtures/auth-fixture.js';

const examples = JSON.parse(fs.readFileSync(new URL('./fixtures/feedback-v1.json', import.meta.url)));
const root = fileURLToPath(new URL('../../', import.meta.url));
// Preference retries wait 1 + 2 + 4 seconds; leave process startup and shutdown headroom.
const CLI_TIMEOUT_MS = 15000;
const dirs = [], servers = [];
afterEach(async () => {
vi.unstubAllGlobals();
Expand Down Expand Up @@ -56,7 +58,7 @@ async function harness(responses, { keySource = 'env' } = {}) {
});
let stdout = '', stderr = '';
child.stdout.on('data', chunk => stdout += chunk); child.stderr.on('data', chunk => stderr += chunk);
const timer = setTimeout(() => { child.kill(); reject(new Error('CLI fixture timed out')); }, 10000);
const timer = setTimeout(() => { child.kill(); reject(new Error('CLI fixture timed out')); }, CLI_TIMEOUT_MS);
child.on('error', reject);
child.on('close', code => { clearTimeout(timer); resolve({ code, stdout, stderr }); });
});
Expand Down
Loading