ci: [SC-66825] run zizmor and fix GitHub Actions findings - #77
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Adds a zizmor CI workflow modeled on narrative-skills-marketplace (PR #108) and fixes the findings it reports. backup-daily.yml: - secrets-inherit: drops 'secrets: inherit'. The called workflow only uses GITHUB_TOKEN, which is passed to called workflows automatically; AWS access comes from the self-hosted runner's instance profile. - excessive-permissions: scopes the workflow to contents: read. library/src/plugins/vue-fontawesome/.github/workflows/ci.yml (removed): All four findings in the vendored tree, including both high-severity ones (unpinned-uses on actions/checkout@v1 and actions/setup-node@v1), came from this single file: a vendored copy of FortAwesome's upstream CI config, untouched since 2020. GitHub only executes workflows under the repository root's .github/workflows/, so it never ran. The vendored library source beside it is untouched and still imported by library/src/index.js, as are the upstream issue templates, which carried no findings. No suppressions added.
mbabic
force-pushed
the
ci/sc-66825/zizmor-ci-and-actions-hardening
branch
from
August 18, 2026 20:45
a66e778 to
c9b513c
Compare
mbabic
commented
Aug 18, 2026
Contributor
Author
There was a problem hiding this comment.
Deleted as it was scanned by zizmor and trigger issues. Arguably should remove entire .github dir here, but wanted to keep scope as small as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs zizmor in CI and fixes the findings it reports. Part of sc-66825; modeled on
narrative-skills-marketplacePR #108, the reference implementation for this ticket.Findings fixed
unpinned-uses×2ci.ymlexcessive-permissionsci.ymlartipackedci.ymlexcessive-permissionsbackup-daily.ymlpermissions: contents: readsecrets-inheritbackup-daily.ymlsecrets: inheritNo suppressions added. Both highs are genuinely fixed, per the ticket's requirement that highs not be muted.