Repository navigation
fix: group dashboard snapshot tables by backup_type and bump lint hooks for Go 1.27 - #223
Merged
Merged
Conversation
gosec v2.29.0 and golangci-lint v2.13.2 are both built with
golang.org/x/tools v0.49.0, which cannot read the export data written
by Go 1.27 ("export data version 5 is greater than maximum supported
version 4"). Every import fails to load and both hooks block every
commit. gosec v2.30.0 and golangci-lint v2.15.0 ship x/tools v0.52.0.
The golangci-lint version in CI is bumped along with the hook so the
two stay in sync.
gosec v2.30.0 also reports G402 when InsecureSkipVerify is set by
assignment. The assignment is guarded by --pbs.insecure / PBS_INSECURE,
an operator opt-in for self-signed PBS certificates that is off by
default, so mark it #nosec with the reason rather than drop the flag.
The CI gosec action tagged v2.30.0 still runs the 2.29.0 image, which
is why CI stayed green. It will report the same G402 once the action
moves to a 2.30 image.
Since #213 the per-VM snapshot metrics carry a backup_type label, so ct/<id> and vm/<id> are separate series. The "last snapshot" and "snapshot count" tables still grouped on datastore, namespace, vm_id and vm_name only. A container and a VM with the same ID and name collapsed back into one row, which is exactly what #213 set out to stop, and the table gave no way to tell the two kinds apart. Add backup_type to both groupBy transformations and show it as a "Type" column in front of the VM ID. Reverting this reintroduces the merged row for a container and a VM that share an ID and a name.
janfuhrer
force-pushed
the
fix/dashboard-backup-type
branch
from
November 5, 2026 08:12
9b0a15b to
48593f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Notes for Reviewer:
Checklist:
feat|fix|chore|docs|...: Changed SomethingREADME.mdfile (e.g. new parameters, environment variables, return values, ...)