Skip to content

Release 2026.3.3#171

Draft
josephbirkner wants to merge 5 commits into
mainfrom
release/2026.3.3
Draft

Release 2026.3.3#171
josephbirkner wants to merge 5 commits into
mainfrom
release/2026.3.3

Refine typed layer schema integration

7147325
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 25, 2026 in 2m 32s

Annotations

Check warning on line 330 in libs/service/src/config.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch a more specific exception instead of a generic one.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUtI9MyAs7EvEZKu&open=AZ7-dUtI9MyAs7EvEZKu&pullRequest=171

Check warning on line 990 in libs/service/src/service.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this const reference to "std::string" by a "std::string_view".

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUt-9MyAs7EvEZK4&open=AZ7-dUt-9MyAs7EvEZK4&pullRequest=171

Check warning on line 337 in libs/service/src/config.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch a more specific exception instead of a generic one.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUtI9MyAs7EvEZKv&open=AZ7-dUtI9MyAs7EvEZKv&pullRequest=171

Check failure on line 57 in test/unit/test-config.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUw69MyAs7EvEZLT&open=AZ7-dUw69MyAs7EvEZLT&pullRequest=171

Check warning on line 72 in libs/model/src/layerschema.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::to_address" to convert iterator to pointer.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7_c7C34NXwFjgq6nm2&open=AZ7_c7C34NXwFjgq6nm2&pullRequest=171

Check warning on line 67 in libs/service/src/config.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch a more specific exception instead of a generic one.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUtI9MyAs7EvEZKq&open=AZ7-dUtI9MyAs7EvEZKq&pullRequest=171

Check warning on line 81 in libs/service/src/config.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "emplace" with "try_emplace".

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUtI9MyAs7EvEZKt&open=AZ7-dUtI9MyAs7EvEZKt&pullRequest=171

Check warning on line 1249 in libs/service/src/service.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid this unnecessary copy by using a "const" reference.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUt-9MyAs7EvEZLB&open=AZ7-dUt-9MyAs7EvEZLB&pullRequest=171

Check failure on line 1848 in libs/model/src/layerschema.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 31 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7_c7C34NXwFjgq6nnL&open=AZ7_c7C34NXwFjgq6nnL&pullRequest=171

Check failure on line 43 in libs/service/include/mapget/service/config.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Give class "DataSourceDescriptor" a noexcept move constructor.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUqZ9MyAs7EvEZKn&open=AZ7-dUqZ9MyAs7EvEZKn&pullRequest=171

Check failure on line 986 in libs/service/src/service.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUt-9MyAs7EvEZK3&open=AZ7-dUt-9MyAs7EvEZK3&pullRequest=171

Check warning on line 1213 in libs/model/src/layerschema.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::move" should not be called on a const object.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7_c7C34NXwFjgq6nnD&open=AZ7_c7C34NXwFjgq6nnD&pullRequest=171

Check warning on line 62 in libs/model/src/info.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "contains" instead of "find".

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7_TXsoKHcoEAf84x2z&open=AZ7_TXsoKHcoEAf84x2z&pullRequest=171

Check warning on line 1617 in libs/model/src/layerschema.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::make_shared" to construct "std::shared_ptr".

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7_c7C34NXwFjgq6nnI&open=AZ7_c7C34NXwFjgq6nnI&pullRequest=171

Check warning on line 2070 in libs/model/src/layerschema.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7_c7C34NXwFjgq6nnU&open=AZ7_c7C34NXwFjgq6nnU&pullRequest=171

Check failure on line 1415 in libs/service/src/service.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Balance the locks and unlocks in this conditional branch.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUt-9MyAs7EvEZLH&open=AZ7-dUt-9MyAs7EvEZLH&pullRequest=171

Check warning on line 1214 in libs/service/src/service.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Pass large object "info" by reference to const.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUt-9MyAs7EvEZK-&open=AZ7-dUt-9MyAs7EvEZK-&pullRequest=171

Check warning on line 1938 in libs/model/src/layerschema.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a static field "attributeTypeCode" in the outer scope.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7_c7C34NXwFjgq6nnM&open=AZ7_c7C34NXwFjgq6nnM&pullRequest=171

Check warning on line 1550 in libs/service/src/service.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "authorized" inside the if statement.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUt-9MyAs7EvEZLK&open=AZ7-dUt-9MyAs7EvEZLK&pullRequest=171

Check failure on line 1632 in libs/model/src/layerschema.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Protect access to the mutable field 'transportJsonSchema_' with a mutex, such as 'transportJsonSchemaMutex_' (e.g., std::scoped_lock _{transportJsonSchemaMutex_}).

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7_c7C34NXwFjgq6nnX&open=AZ7_c7C34NXwFjgq6nnX&pullRequest=171

Check failure on line 1608 in libs/model/src/layerschema.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Protect access to the mutable field 'transportJsonSchema_' with a mutex, such as 'transportJsonSchemaMutex_' (e.g., std::scoped_lock _{transportJsonSchemaMutex_}).

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7_c7C34NXwFjgq6nnW&open=AZ7_c7C34NXwFjgq6nnW&pullRequest=171

Check warning on line 19 in libs/http-service/src/sources-handler.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce verbosity with "using enum" for "mapget::DataSourceCatalogStatus".

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUuS9MyAs7EvEZLO&open=AZ7-dUuS9MyAs7EvEZLO&pullRequest=171

Check warning on line 74 in libs/service/src/config.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7-dUtI9MyAs7EvEZKr&open=AZ7-dUtI9MyAs7EvEZKr&pullRequest=171

Check failure on line 503 in libs/model/src/layerschema.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7_c7C34NXwFjgq6nm-&open=AZ7_c7C34NXwFjgq6nm-&pullRequest=171

Check warning on line 1631 in libs/model/src/layerschema.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::make_shared" to construct "std::shared_ptr".

See more on https://sonarcloud.io/project/issues?id=ndsev_mapget&issues=AZ7_c7C34NXwFjgq6nnJ&open=AZ7_c7C34NXwFjgq6nnJ&pullRequest=171