-
Notifications
You must be signed in to change notification settings - Fork 41
fix(runtime): helper-lifecycle follow-ups (#666, #667, #668) and a detached-reap regression #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
52d92c1
fix(codex): stop runtime helpers from leaking past their idle timeout
possibilities f5bf873
fix(codex): address CodeRabbit round 1 on the helper-leak fix
possibilities 1590cd1
test(codex): pin the sweep-retry test to the four-attempt budget, ord…
possibilities 6bb2049
fix(codex): reap app helpers stranded by the detach grace
possibilities c18a5df
fix(codex): degrade an unreadable connection count to zero
possibilities c03af14
fix(codex): correct the connection-count comment and cover the reap o…
possibilities e57da41
fix(codex): accept only a positive socket count as evidence of a cons…
possibilities 16a335f
test: add owned-PID probes for helper-lifecycle fixtures (#668)
ndycode bf0a749
fix(codex): reap only helpers that were never handed to a consumer
ndycode 040e0c1
fix(runtime): stop unbind from orphaning helper owner files (#666)
ndycode 7c10722
refactor(runtime): one identity-checked helper selector for both read…
ndycode 109db04
docs: correct the runtime app helper status path in the README
ndycode 51c5ca4
refactor(runtime): narrow the helper PID instead of casting it
ndycode c42bf54
fix(runtime): address the review on the helper-lifecycle follow-ups
ndycode e087c43
test: stress the helper lifecycle at the scale the leak report described
ndycode 8f0b578
test: fix the review round on the stress suite
ndycode 6b9f327
test: make the spawn-failure coverage exercise the helpers, not node
ndycode 02e0c9b
test: cover the failed-spawn branch in withLivePid
ndycode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.