Fix panic in format() on negative replacement index - #6136
Open
semx wants to merge 1 commit into
Open
Conversation
|
Verified locally against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
format()panics withruntime error: index out of range [-1]when a placeholder uses a negative index, e.g.format('{-1}', 'x').When parsing a
{N}placeholder, the-and digits are collected intoreplacementIndex, sostrconv.ParseInt("-1", 10, 32)succeeds and returns-1. The only guards were a parse error and an index that is too large (len(replaceValue) <= int(index)), which isfalsefor a negative index. Execution then reachesreplaceValue[index]with a negative index and the runtime panics.GitHub Actions instead returns a handled expression error for such input, the same way
actalready handles the out-of-range case{2147483648}.Reproduction
Before:
panic: runtime error: index out of range [-1]After: returns error
The following format string is invalid: '{-1}'Fix
Reject a negative index alongside the existing parse-error guard. A test case
format('{-1}', 'x')is added next to the existing{2147483648}case.