Skip to content

fix(artifactcache): return after storage.Write error on upload (rebase of #6132) - #6139

Closed
louzt wants to merge 1 commit into
nektos:masterfrom
LOUST-PRO:pr-6132-rebased
Closed

fix(artifactcache): return after storage.Write error on upload (rebase of #6132)#6139
louzt wants to merge 1 commit into
nektos:masterfrom
LOUST-PRO:pr-6132-rebased

Conversation

@louzt

@louzt louzt commented Jul 28, 2026

Copy link
Copy Markdown

Summary

Fix silent data loss in artifact upload: when storage.Write fails mid-upload, the handler currently continues processing instead of returning the error.

What

  • Return early after storage.Write error in artifact upload path
  • Test verifies error propagation through handler response

Rebase status

Rebased against current master (4f41128). Zero conflicts. Tests pass.

@mergify

mergify Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

⚠️ The sha of the head commit of this PR conflicts with #6132. Mergify cannot evaluate rules on this PR. Once #6132 is merged or closed, Mergify will resume processing this PR. ⚠️

@louzt

louzt commented Jul 28, 2026

Copy link
Copy Markdown
Author

Closing this PR — I verified the missing-return fix locally against act master HEAD 4f41128; the head commit is the same SHA as the still-active #6132 from @baiyuxi930826, so no added value in opening a duplicate. Thanks to the original author for the fix.

@louzt louzt closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants