Skip to content

fix(rtl): use CSS logical properties for problem blocks and remove ha… #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrey-canon merged 1 commit into from
Jul 16, 2026
Merged

fix(rtl): use CSS logical properties for problem blocks and remove ha… #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion common/static/sass/_builtin-block-variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
@import 'cms/static/sass/partials/cms/theme/_variables';
@import 'cms/static/sass/partials/cms/theme/_variables-v1';
@import 'bootstrap/scss/variables';
@import 'vendor/bi-app/bi-app-ltr';
@import 'edx-pattern-library-shims/base/_variables.scss';

:root {
Expand Down
6 changes: 3 additions & 3 deletions xmodule/static/css-builtin-blocks/ProblemBlockDisplay.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@
.xmodule_display.xmodule_ProblemBlock div.problem .choicegroup input[type="checkbox"],
.xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup input[type="checkbox"] {
margin: calc((var(--baseline, 20px) / 4));
margin-right: calc((var(--baseline, 20px) / 2));
margin-inline-end: calc((var(--baseline, 20px) / 2));
}

.xmodule_display.xmodule_ProblemBlock div.problem .choicegroup input:focus+label,
Expand Down Expand Up @@ -394,7 +394,7 @@

.xmodule_display.xmodule_ProblemBlock div.problem .choicegroup label {
padding: calc((var(--baseline, 20px) / 2));
padding-left: calc((var(--baseline, 20px) * 2.3));
padding-inline-start: calc((var(--baseline, 20px) * 2.3));
position: relative;
font-size: var(--base-font-size, 18px);
line-height: normal;
Expand All @@ -403,7 +403,7 @@

.xmodule_display.xmodule_ProblemBlock div.problem .choicegroup input[type="radio"],
.xmodule_display.xmodule_ProblemBlock div.problem .choicegroup input[type="checkbox"] {
left: 0.5625em;
inset-inline-start: 0.5625em;
position: absolute;
top: 0.35em;
width: calc(var(--baseline, 20px) * 1.1);
Expand Down
Loading