Repository navigation
Conversation
The longitude half-width r / cos(lat) is too narrow away from the equator, so spatial.withinDistance missed points near the edge of the distance. The window also never wrapped at the antimeridian and grew past the poles; it now spans all longitudes in those cases.
This was referenced Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spatial.withinDistance(and, after #498,spatial.closest) found candidates in a lon/lat search window that could miss points within the distance:The window now uses the exact great-circle width, and spans every longitude when the circle reaches a pole or crosses ±180°.
Longitudes are expected in -180..180; values stored in a 0..360 range are not found across the antimeridian.
Out of scope