Wire hardcoded frontend strings into locale system#187
Merged
Finesssee merged 2 commits intoJul 13, 2026
Conversation
Several components rendered English UI text directly instead of going through t(), bypassing the existing i18n system. Most were pre-i18n codepaths (CookiesTab, ApiKeySection) or surfaces never migrated (floatbar/SettingsSection, AboutTab update flow, OpenAiExtras). - Add ~70 new LocaleKey variants (synced across locale.rs, keys.ts, en-US.ftl) - Replace hardcoded literals with t() in 17 components - Many strings reuse already-existing keys that were simply not wired up - Update affected test assertions
Collaborator
|
Thanks for the PR, I will review it ASAP |
Collaborator
|
Follow-up validation at the current head (8a17e63): the previously reported issues are not fixed yet.
Before merging, please address:
|
Author
|
Thanks for the detailed validation. I addressed each item at the current head:
Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several frontend components rendered English UI text directly instead of going through
t(), bypassing the existing i18n system. Most were pre-i18n codepaths (CookiesTab,ApiKeySection) or surfaces that were never migrated (floatbar/SettingsSection,AboutTabupdate flow,OpenAiExtras).This wires all of them into the existing
t(key)mechanism. No new i18n architecture — it reuses the current key-in-Rust / strings-in-.ftldesign.What changed
LocaleKeyvariants (synced acrossrust/src/locale.rs,keys.ts, anden-US.ftl).t(...)calls in 17 components, including:floatbar/SettingsSection,AboutTab,CookiesTab,ApiKeySection/ApiKeysTab,OpenAiExtras,GeneralTab(refresh-cadence options + provider display names),Settings,App,PopOutTitleBar,ProvidersSidebar,ProvidersTab,TokenAccountsPanel,IdentitySection/MenuCard,PaceDetailsChart/MiniBarChart(added optionaltprop),AgentSessions.Save,Cancel,Version,KeySet,BrowserCookieSave, etc.) that were simply not wired up.Notes
en-US.ftl; non-English translations are in a follow-up PR).Verification
```
pnpm --dir apps/desktop-tauri run check-locale # 668 keys match Rust ↔ TS
pnpm --dir apps/desktop-tauri exec tsc --noEmit # 0 errors
pnpm --dir apps/desktop-tauri test # 152/152 passed
cargo test --manifest-path rust/Cargo.toml
cargo fmt --all
```
No CUA Driver capture available in my environment; validated by launching `tauri dev` and confirming previously-English surfaces now resolve through the locale bundle. Happy to add screenshots if helpful.