Skip to content

Drop regional suffix from Traditional Chinese label#188

Merged
Finesssee merged 1 commit into
nesszer:mainfrom
SnowfallC:pr/drop-regional-suffix-traditional-chinese
Jul 13, 2026
Merged

Drop regional suffix from Traditional Chinese label#188
Finesssee merged 1 commit into
nesszer:mainfrom
SnowfallC:pr/drop-regional-suffix-traditional-chinese

Conversation

@SnowfallC

Copy link
Copy Markdown

Summary

The Traditional Chinese option in the language picker was labeled 繁體中文(臺灣). This drops the (臺灣) regional suffix so the label reads simply 繁體中文.

Why

Traditional Chinese is not specific to Taiwan. It is the standard written script in Hong Kong and Macau as well, and zh-Hant (the BCP-47 tag this language maps to) is script-based rather than region-based. Tying the label to a single region is misleading for users in HK/Macau. The bare 繁體中文 matches how most cross-region Chinese software labels this option (e.g. macOS, iOS, Google products).

What changed

  • `rust/src/settings/types.rs`: `display_name()` returns `"繁體中文"`.
  • `GeneralTab.tsx`: fallback `LanguageOption` display updated to match.
  • Matching test assertions in `settings/tests.rs`, `locale_cmd.rs`, and `GeneralTab.test.tsx`.

The `value` (`"chinesetraditional"`), the `zh-tw`/`zh-hant` aliases in `parse_locale_language`, and the `.ftl` filename are all unchanged — only the user-facing label.

Verification

```
cargo test --manifest-path rust/Cargo.toml settings::tests
pnpm --dir apps/desktop-tauri test
cargo fmt --all
```

The Traditional Chinese option was labeled 繁體中文(臺灣). Traditional Chinese is the standard written script in Hong Kong and Macau as well as Taiwan, and the underlying zh-Hant tag is script-based, not region-based. Dropping (臺灣) matches how most cross-region Chinese software labels this option.

Only the user-facing display label changes; the value, aliases, and .ftl filename are unchanged.
@Finesssee

Copy link
Copy Markdown
Collaborator

Thanks for the PR, I will review it ASAP

@Finesssee
Finesssee merged commit 5da1b92 into nesszer:main Jul 13, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants